Postgres Pro
Downloads
Home   >   mailing lists

Re: WIP Patch: Selective binary conversion of CSV file foreign tables - Mailing list pgsql-hackers

From Tom Lane
Subject Re: WIP Patch: Selective binary conversion of CSV file foreign tables
Date
Msg-id 9173.1342125014@sss.pgh.pa.us
Whole thread Raw
In response to Re: WIP Patch: Selective binary conversion of CSV file foreign tables  ("Etsuro Fujita" <fujita.etsuro@lab.ntt.co.jp>)
Responses Re: WIP Patch: Selective binary conversion of CSV file foreign tables  ("Etsuro Fujita" <fujita.etsuro@lab.ntt.co.jp>)
List pgsql-hackers
Tree view 
"Etsuro Fujita" <fujita.etsuro@lab.ntt.co.jp> writes:
> Besides the revision, I modified check_selective_binary_conversion() to run
> heap_close() in the whole-row-reference case.  Attached is an updated version of
> the patch.

Applied with minor, mostly-cosmetic revisions.  I did fix
check_selective_binary_conversion to not continue touching the
relation's tupledesc after heap_close.  Also I thought
"convert_selectively" was a better name for the hidden COPY option.
        regards, tom lane

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: WIP pgindent replacement
Next
From: Shaun Thomas
Date:
Subject: Re: Synchronous Standalone Master Redoux