Re: Increase psql's password buffer size - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Increase psql's password buffer size
Date
Msg-id 9162.1582145316@sss.pgh.pa.us
Whole thread Raw
In response to Re: Increase psql's password buffer size  (Fujii Masao <masao.fujii@oss.nttdata.com>)
List pgsql-hackers
Fujii Masao <masao.fujii@oss.nttdata.com> writes:
> Attached is the patch that Nathan proposed at [1] and I think that
> it's worth applying. I'd like to add this to next CommitFest.
> Thought?

I can't get excited about this in the least.  For any "normal" use of
passwords, 100 bytes is surely far more than sufficient.  Furthermore,
if there is someone out there for whom it isn't sufficient, they're not
going to want to build custom versions of Postgres to change it.

If we think that longer passwords are actually a thing to be concerned
about, then what we need to do is change all these places to support
expansible buffers.  I'm not taking a position on whether that's worth
the trouble ... but I do take the position that just inserting a
#define is a waste of time.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Justin Pryzby
Date:
Subject: Re: error context for vacuum to include block number
Next
From: Tom Lane
Date:
Subject: Re: Delaying/avoiding BTreeTupleGetNAtts() call within _bt_compare()