Re: VM corruption on standby - Mailing list pgsql-hackers

From Yura Sokolov
Subject Re: VM corruption on standby
Date
Msg-id 91495849-ebf7-4f7e-8cca-ec718964d256@postgrespro.ru
Whole thread Raw
In response to Re: VM corruption on standby  (Kirill Reshke <reshkekirill@gmail.com>)
Responses Re: VM corruption on standby
List pgsql-hackers
09.08.2025 22:54, Kirill Reshke пишет:
> On Thu, 7 Aug 2025 at 21:36, Aleksander Alekseev
> <aleksander@tigerdata.com> wrote:
>
>> Perhaps there was a good
>> reason to update the VM *before* creating WAL records I'm unaware of.
>
> Looks like 503c730 intentionally does it this way; however, I have not
> yet fully understood the reasoning behind it.

I repeat: there was no intention. Neither in commit message, nor in
discussion about.

There was intention to move visibilitymap_clear under heap page lock and
into critical section, but there were no any word about logging.

I believe, it was just an unfortunate oversight that the change is made
before logging.

--
regards
Yura Sokolov aka funny-falcon



pgsql-hackers by date:

Previous
From: "Hayato Kuroda (Fujitsu)"
Date:
Subject: RE: ReplicationSlotRelease() crashes when the instance is in the single user mode
Next
From: Andres Freund
Date:
Subject: Re: VM corruption on standby