Postgres Pro
Downloads
Home   >   mailing lists

Re: check_recovery_target_lsn() does a PG_CATCH without a throw - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: check_recovery_target_lsn() does a PG_CATCH without a throw
Date
Msg-id 910a4421-f0bc-0e5f-8617-0d467627b30e@2ndquadrant.com
Whole thread Raw
In response to Re: check_recovery_target_lsn() does a PG_CATCH without a throw  (Michael Paquier <michael@paquier.xyz>)
Responses Re: check_recovery_target_lsn() does a PG_CATCH without a throw
List pgsql-hackers
Tree view 
On 2019-06-24 06:06, Michael Paquier wrote:
> -       if (strcmp(*newval, "epoch") == 0 ||
> -           strcmp(*newval, "infinity") == 0 ||
> -           strcmp(*newval, "-infinity") == 0 ||
> Why do you remove these?  They should still be rejected because they
> make no sense as recovery targets, no?

Yeah but the new code already rejects those anyway.  Note how
timestamptz_in() has explicit switch cases to accept those, and we
didn't carry those over into check_recovery_time().

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: more Unicode data updates
Next
From: James Coleman
Date:
Subject: Re: [PATCH] Incremental sort (was: PoC: Partial sort)