Re: Remove MSVC scripts from the tree - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Remove MSVC scripts from the tree
Date
Msg-id 90aa6653-3cea-42ed-8b62-1cfc9675aad3@eisentraut.org
Whole thread Raw
In response to Re: Remove MSVC scripts from the tree  (Andres Freund <andres@anarazel.de>)
Responses Re: Remove MSVC scripts from the tree
Re: Remove MSVC scripts from the tree
List pgsql-hackers
On 20.12.23 12:40, Andres Freund wrote:
> Hm, or perhaps we should just get rid of sed use altogether. The sepgsql case
> is trivially translateable to perl, and postprocess_dtrace.sed isn't
> much harder.

Maybe yeah, but also it seems fine as is and we can easily fix the 
present issue ...

> OTOH, I actually don't think it's valid to not have sed when you have
> dtrace. Erroring out in a weird way in such an artificially constructed test
> doesn't really seem like a problem.

Agreed.  So let's just make it not-required, and that should work.

Updated patch set attached.

Attachment

pgsql-hackers by date:

Previous
From: "Tristan Partin"
Date:
Subject: Re: Unchecked strdup leading to segfault in pg_dump
Next
From: Emre Hasegeli
Date:
Subject: Re: "pgoutput" options missing on documentation