Re: [patch] executor and slru dtrace probes - Mailing list pgsql-hackers

From Bernd Helmle
Subject Re: [patch] executor and slru dtrace probes
Date
Msg-id 90EAEBC221850A39B4AB556D@amenophis
Whole thread Raw
In response to Re: [patch] executor and slru dtrace probes  (Greg Smith <greg@2ndquadrant.com>)
List pgsql-hackers

--On 15. Dezember 2009 12:10:09 -0500 Greg Smith <greg@2ndquadrant.com>
wrote:

> But I'm afraid we're already out of time for this one if you're still
> tweaking the probes here.  With a functional change like that, our
> normal process at this point would be to have the reviewer re-evaluate
> things before they head to a committer, and I don't feel like this patch
> is quite at 100% yet--in particular, the probe documentation is improving
> but still a bit rough.  I don't feel like we're quite ready to mark this
> one for commit for this one, and today we really want to clear the queue
> for things for committers to deal with.  Please send that updated
> version, and let's keep working on this into the next CommitFest, where
> it will be in the front of the queue rather than how it ended up at the
> tail of this one just based on its submission date.  You're not really
> getting a fair chunk of time here between your review and the end here
> because of problems lining up reviewer time, that shouldn't happen next
> time.

That seems reasonable.

I hope i could contribute something, even this was the first time i got my
hands on reviewing this DTrace thingie.

--
Thanks
Bernd


pgsql-hackers by date:

Previous
From: Marko Kreen
Date:
Subject: Re: Patch: Remove gcc dependency in definition of inline functions
Next
From: Tom Lane
Date:
Subject: Re: Range types