On 01/09/26 19:47, Jan Nidzwetzki wrote:
> Hello Matheus,
>
> On 01.09.26 23:20, Jan Nidzwetzki wrote:
>> On 01.09.26 21:37, Matheus Alcantara wrote:
>>> I think it's right, the citext case now plans as partial aggregation and
>>> returns the correct single group. So v8 looks good to me.
>> Thank you for reviewing and confirming. I ran additional tests on v8 and
>> found no further issues. The patch series looks good to me as well.
> Sorry for the extra round. I noticed that v8 does not pass the tests on
> all platforms. The partition bounds 'A' and 'a' in the test I added sort
> differently depending on the collation, which changes the order of the
> Append children on macOS and Windows. Since the test type compares
> case-insensitively, it also changes which of the two values is reported
> for the group.
>
> Attached is v9. It adds COLLATE "C" to the partition key of that test,
> so the partition order is stable everywhere. This is a test-only change;
> no code changed, and patches 1 to 3 are unmodified.
>
Thank you for the new patch version. It looks good to me.
I'll mark the CF entry to Ready for committer since the current state
of the review. I can move back to Needs review if more comments shows
up.
--
Matheus Alcantara
EDB: https://www.enterprisedb.com
