Postgres Pro
Downloads
Home   >   mailing lists

Re: [dynahash] do not refill the hashkey after hash_search - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [dynahash] do not refill the hashkey after hash_search
Date
Msg-id 908921.1698211292@sss.pgh.pa.us
Whole thread Raw
In response to Re: [dynahash] do not refill the hashkey after hash_search  (John Naylor <johncnaylorls@gmail.com>)
Responses Re: [dynahash] do not refill the hashkey after hash_search
List pgsql-hackers
Tree view 
John Naylor <johncnaylorls@gmail.com> writes:
> I'd prefer just adding "Assert(hentry->event == oldn);" and declaring
> hentry PG_USED_FOR_ASSERTS_ONLY.

I'm not aware of any other places where we have Asserts checking
that hash_search() honored its contract.  Why do we need one here?

            regards, tom lane

pgsql-hackers by date:

Previous
From: John Naylor
Date:
Subject: Re: [dynahash] do not refill the hashkey after hash_search
Next
From: Thomas Munro
Date:
Subject: Re: Guiding principle for dropping LLVM versions?