Re: Trigger regression test output - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Trigger regression test output
Date
Msg-id 9086.1033664263@sss.pgh.pa.us
Whole thread Raw
In response to Trigger regression test output  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Trigger regression test output
List pgsql-hackers
I said:
> I am inclined to have the refint.c code emit the notice unconditionally
> at DEBUG1 level, and then add a "SET client_min_messages = DEBUG1" in
> the triggers regression test to ensure the notice will appear.

Hmm, that doesn't look that good after all: the SET causes the
regression output to be cluttered with a whole *lot* of chatter,
which will doubtless change constantly and break the test regularly.

Plan B is to make the refint.c code emit the message at NOTICE level,
but to change the contrib makefile so that REFINT_VERBOSE is defined
by default (ie, you gotta edit the makefile if you don't want it).
This will work nicely for the regression tests' purposes.  If there is
anyone out there actually using refint.c in production, they might be
annoyed by the NOTICE chatter, but quite honestly I doubt anyone is ---
this contrib module has long since been superseded by standard
foreign-key support.

Comments?
        regards, tom lane


pgsql-hackers by date:

Previous
From: "scott.marlowe"
Date:
Subject: Re: Correlation in cost_index()
Next
From: Justin Clift
Date:
Subject: Re: [GENERAL] Anyone want to assist with the translation of theAdvocacy