Re: Teach pg_upgrade test to honor NO_TEMP_INSTALL - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Teach pg_upgrade test to honor NO_TEMP_INSTALL
Date
Msg-id 9041.1553982506@sss.pgh.pa.us
Whole thread Raw
In response to Teach pg_upgrade test to honor NO_TEMP_INSTALL  (Andrew Dunstan <andrew.dunstan@2ndquadrant.com>)
List pgsql-hackers
Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
> On some machines (*cough* Mingw *cough*) installs are very slow. We've
> ameliorated this by allowing temp installs to be reused, but the
> pg_upgrade Makefile never got the message. Here's a patch that does
> that. I'd like to backpatch it, at least to 9.5 where we switched the
> pg_upgrade location. The risk seems appropriately low and it only
> affects our test regime.

I haven't tested this, but it looks reasonable.

I suspect you need double-quotes around the path values, as in
the adjacent usage of EXTRA_REGRESS_OPTS.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: pgsql: Compute XID horizon for page level index vacuum on primary.
Next
From: Justin Pryzby
Date:
Subject: clean up docs for v12