Re: CVS compile failure - Mailing list pgsql-hackers

From Tom Lane
Subject Re: CVS compile failure
Date
Msg-id 9040.1090213833@sss.pgh.pa.us
Whole thread Raw
In response to Re: CVS compile failure  ("Marc G. Fournier" <scrappy@postgresql.org>)
Responses Re: CVS compile failure  ("Marc G. Fournier" <scrappy@postgresql.org>)
List pgsql-hackers
"Marc G. Fournier" <scrappy@postgresql.org> writes:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
>> I am seeing a compile failure in current CVS from strptime():
>> ./backend/access/transam/xlog.c:    if (strptime(tok2, "%Y-%m-%d %H:%M:%S", &tm) == NULL)
>> BSD/OS does not have that function.

> Under FreeBSD:
> "     The strptime() function does not correctly handle multibyte characters in
>       the format argument"
> Not sure how critical that is for what you are doing, mind you ...

Not at all, since in this call the format is the fixed constant
"%Y-%m-%d %H:%M:%S".  But it's odd that your BSD variant has strptime()
where Bruce's does not.

I suppose it doesn't much matter though: we have to recode without
strptime.  No big deal.  I'll fix it tomorrow if no one beats me to it.
        regards, tom lane


pgsql-hackers by date:

Previous
From: "Marc G. Fournier"
Date:
Subject: Re: CVS compile failure
Next
From: Simon Riggs
Date:
Subject: Re: Why we really need timelines *now* in PITR