Re: [HACKERS] document and use SPI_result_code_string() - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] document and use SPI_result_code_string()
Date
Msg-id 9035.1504700756@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] document and use SPI_result_code_string()  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: [HACKERS] document and use SPI_result_code_string()  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-hackers
Michael Paquier <michael.paquier@gmail.com> writes:
> Fine for 0002. This reminds me of LockGXact and RemoveGXact in
> twophase.c, as well as _hash_squeezebucket that have some code paths
> that cannot return... Any thoughts about having some kind of
> PG_NOTREACHED defined to 0 which could be put in an assertion?

Generally we just do "Assert(false)", maybe with "not reached" in a
comment.  I don't feel a strong need to invent a new way to do that.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Sokolov Yura
Date:
Subject: Re: [HACKERS] Fix performance of generic atomics
Next
From: Simon Riggs
Date:
Subject: Re: [HACKERS] Fix performance of generic atomics