Re: BUG #18960: Mistake in test test_simple_pipeline (libpq_pipeline.c) - Mailing list pgsql-bugs

From Tom Lane
Subject Re: BUG #18960: Mistake in test test_simple_pipeline (libpq_pipeline.c)
Date
Msg-id 901577.1756930252@sss.pgh.pa.us
Whole thread Raw
In response to Re: BUG #18960: Mistake in test test_simple_pipeline (libpq_pipeline.c)  (Álvaro Herrera <alvherre@kurilemu.de>)
List pgsql-bugs
=?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de> writes:
> On 2025-Sep-03, Tom Lane wrote:
>> Hm, I chose that name by analogy to the adjacent
>> confirm_query_canceled(), which is likewise consuming a result.
>> I agree that "consume" is a better verb, but then let's rename
>> confirm_query_canceled as well.

> Ah, that explains it -- my bad, then, I suppose.  That change works for
> me.

After reflection, I used "consume_xxx" for the void-returning helper
functions, but kept the "confirm_xxx" terminology for the helper
function that returns a PGresult after confirming its status is
as-expected.  Pushed with those renamings.

            regards, tom lane



pgsql-bugs by date:

Previous
From: Andres Freund
Date:
Subject: Re: BUG #19042: Option --help not recognized at the end of command line in pg_restore
Next
From: Greg Sabino Mullane
Date:
Subject: Re: empty,query_id, pg_stat_activity