Re: Race condition in recovery? - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: Race condition in recovery?
Date
Msg-id 8f697ce3-d795-051a-35a6-18d32c7db1a0@dunslane.net
Whole thread Raw
In response to Re: Race condition in recovery?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 6/12/21 1:54 PM, Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
>> On 6/12/21 1:07 PM, Tom Lane wrote:
>>> OK.  But it makes me itch a bit that this one wait-for-wal-to-be-
>>> processed query looks different from all the other ones.
>> I'm happy to bring the other two queries that look like this into line
>> with this one if you like.
> I see a lot more than two --- grepping for poll_query_until with
> a test involving a LSN comparison finds a bunch.  Are we sure that
> there are only three in which the LSN could be null?  


Well, I'm counting places that specifically compare it with
pg_stat_archiver.last_archived_wal.



> How much
> does it really matter if it is?
>
>             


It makes it harder to tell if there was any result at all when there's a
failure. If it bugs you that much I can revert just that line. Now that
I have fixed the immediate issue it matters less. I'm not prepared to
put in a lot of effort here, though.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com




pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: recovery test failures on hoverfly
Next
From: Fabien COELHO
Date:
Subject: Re: Error on pgbench logs