Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h - Mailing list pgsql-committers

From David Steele
Subject Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h
Date
Msg-id 8ea10012-50bc-5770-8882-622721e45194@pgmasters.net
Whole thread Raw
In response to Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h  (Michael Paquier <michael@paquier.xyz>)
List pgsql-committers
Tree view 
On 3/5/20 6:30 PM, Michael Paquier wrote:
> On Thu, Mar 05, 2020 at 12:51:50PM -0500, David Steele wrote:
> 
>> Bit of a bummer that this passed make check-world, but the pgBackRest tests
>> definitely did not like it.
> 
> Is that because you have a copy of this routine in your code?

Yes, we pull this file into pgBackRest for our checksum validation.  We 
also do unit and integration tests against it.

Regards,
-- 
-David
david@pgmasters.net

pgsql-committers by date:

Previous
From: David Steele
Date:
Subject: Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h
Next
From: Michael Paquier
Date:
Subject: Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h