Re: Review for GetWALAvailability() - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Review for GetWALAvailability()
Date
Msg-id 8dcae742-7892-ad82-b787-1ac05cb878d8@oss.nttdata.com
Whole thread Raw
In response to Re: Review for GetWALAvailability()  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
List pgsql-hackers

On 2020/06/18 16:36, Kyotaro Horiguchi wrote:
> Mmm. I hurried too much..
> 
> At Thu, 18 Jun 2020 16:32:59 +0900 (JST), Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote in
>> If name is specified (so slot is NULL) to
>> ReplicationSlotAcquireInternal and the slot is not found, the ereport
>> in following code dereferences NULL.
> 
> That's bogus. It is using name in that case. Sorry for the noise.
> 
> I don't find a problem by a brief look on it.

Thanks for the review! I pushed the patch.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION



pgsql-hackers by date:

Previous
From: "Andrey V. Lepikhov"
Date:
Subject: Re: Global snapshots
Next
From: Andy Fan
Date:
Subject: hash as an search key and hash collision