Re: Improve error handling of HMAC computations and SCRAM - Mailing list pgsql-hackers

From Sergey Shinderuk
Subject Re: Improve error handling of HMAC computations and SCRAM
Date
Msg-id 8cbb56dd-63d6-a581-7a65-25a97ac4be03@postgrespro.ru
Whole thread Raw
In response to Re: Improve error handling of HMAC computations and SCRAM  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Improve error handling of HMAC computations and SCRAM
List pgsql-hackers
On 12.01.2022 14:32, Michael Paquier wrote:
> On Wed, Jan 12, 2022 at 12:56:17PM +0900, Michael Paquier wrote:
>> Attached is a rebased patch for the HMAC portions, with a couple of
>> fixes I noticed while going through this stuff again (mostly around
>> SASLprep and pg_fe_scram_build_secret), and a fix for a conflict
>> coming from 9cb5518.  psql's \password is wrong to assume that the
>> only error that can happen for scran-sha-256 is an OOM, but we'll get
>> there.
> 
> With an attachment, that's even better.  (Thanks, Daniel.)
Gave it a thorough read.  Looks good, except for errstr not set in a 
couple of places (see the diff attached).

Didn't test it.

-- 
Sergey Shinderuk        https://postgrespro.com/
Attachment

pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: PATCH: generate fractional cheapest paths in generate_orderedappend_path
Next
From: Thomas Munro
Date:
Subject: Re: Stream replication test fails of cfbot/windows server 2019