bugfix: when the blocksize is 32k, the function page_header of pageinspect returns negative numbers. - Mailing list pgsql-hackers

From Quan Zongliang
Subject bugfix: when the blocksize is 32k, the function page_header of pageinspect returns negative numbers.
Date
Msg-id 8b8ec36e-61fe-14f9-005d-07bc85aa4eed@yeah.net
Whole thread Raw
Responses Re: bugfix: when the blocksize is 32k, the function page_header of pageinspect returns negative numbers.  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
List pgsql-hackers
If the block size is 32k, the function page_header of the pageinspect 
module returns negative numbers:

postgres=# select * from page_header(get_raw_page('t1',0));
     lsn    | checksum | flags | lower | upper | special | pagesize | 
version | prune_xid
-----------+----------+-------+-------+-------+---------+----------+---------+-----------
  0/174CF58 |        0 |     0 |    28 | 32736 |  -32768 |   -32768 | 
    4 |         0
(1 row)


This patch changes the output parameters lower, upper, special and 
pagesize to int32.

postgres=# select * from page_header(get_raw_page('t1',0));
     lsn    | checksum | flags | lower | upper | special | pagesize | 
version | prune_xid
-----------+----------+-------+-------+-------+---------+----------+---------+-----------
  0/19EA640 |        0 |     0 |    28 | 32736 |   32768 |    32768 | 
    4 |         0
(1 row)


--
Quan Zongliang

Attachment

pgsql-hackers by date:

Previous
From: Peter Smith
Date:
Subject: Re: Refactor "mutually exclusive options" error reporting code in parse_subscription_options
Next
From: Greg Nancarrow
Date:
Subject: Re: row filtering for logical replication