Re: [19] CREATE SUBSCRIPTION ... SERVER - Mailing list pgsql-hackers

From Jeff Davis
Subject Re: [19] CREATE SUBSCRIPTION ... SERVER
Date
Msg-id 8b475aa7327fa489d93e4a096e9d30f90aef588f.camel@j-davis.com
Whole thread Raw
In response to Re: [19] CREATE SUBSCRIPTION ... SERVER  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
On Tue, 2026-03-17 at 11:29 +0530, Amit Kapila wrote:
> Yeah, or the other possibility could be to let the newsub information
> get allocated in the current transaction context and reset the
> subscription context if we decide not to exit from the worker. Then
> copy/get the subscription info in subscription context but not sure
> if
> that is worth it.

Then we have to invent a deep copy for the Subscription, and we've
already seen that the FreeSubscrpition() method was not being
maintained properly.

> The minor oddity in the proposed approach is that
> the worker will exit in many cases after allocating the new context
> but that may be the best we can do here.

Agreed.

Regards,
    Jeff Davis




pgsql-hackers by date:

Previous
From: Anthonin Bonnefoy
Date:
Subject: Re: Shutdown indefinitely stuck due to unflushed FPI_FOR_HINT record
Next
From: Heikki Linnakangas
Date:
Subject: Assertion failure in hash_kill_items()