Re: Remove unused function parameters, part 2: replication - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Remove unused function parameters, part 2: replication
Date
Msg-id 8AA7C16B-45D6-4150-A0D5-14451539C68C@yesql.se
Whole thread Raw
In response to Re: Remove unused function parameters, part 2: replication  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
> On 2 Dec 2025, at 08:32, Michael Paquier <michael@paquier.xyz> wrote:

> Simple example I have seen in the past: a Relation argument not used
> (I think there has been at least one such example in tablecmds.c,
> whatever).  Removing this argument also meant that we don't require
> function callers to open a Relation, removing the need to think about
> the lock it would require at open.

I think this is the really interesting case and the angle to focus on.  If we
can simplify callers to perhaps even avoid locks then that's a stronger case
when considering potential API breaks.  It might still be more value in not
breaking API, but that would have to be considered on a case by case basis.

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Ajin Cherian
Date:
Subject: Re: Improve pg_sync_replication_slots() to wait for primary to advance
Next
From: vignesh C
Date:
Subject: Re: POC: enable logical decoding when wal_level = 'replica' without a server restart