Re: Fixing MSVC's inability to detect elog(ERROR) does not return - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Fixing MSVC's inability to detect elog(ERROR) does not return
Date
Msg-id 899795.1783289731@sss.pgh.pa.us
Whole thread
In response to Re: Fixing MSVC's inability to detect elog(ERROR) does not return  (David Rowley <dgrowleyml@gmail.com>)
List pgsql-hackers
David Rowley <dgrowleyml@gmail.com> writes:
> On Mon, 6 Jul 2026 at 03:18, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> It came to my attention just now that 59c2f03d1 adjusted ereport()
>> to be MSVC-friendly, but did not touch plpy_elog.h's PLy_elog(),
>> which has a borrowed copy of the same logic.  Was that intentional?

> That was unintentional and caused by my unawareness of that version of
> the macro.

>> It seems like we should keep those looking alike.

> Agreed.

Cool.  You wanna fix it, or shall I?

            regards, tom lane



pgsql-hackers by date:

Previous
From: Jeremy Schneider
Date:
Subject: hang during shutdown
Next
From: Noah Misch
Date:
Subject: Re: PG19 FK fast path: OOB write and missed FK checks during batched