Re: cleanup execTuples.c - Mailing list pgsql-patches

From Tom Lane
Subject Re: cleanup execTuples.c
Date
Msg-id 8980.1069388502@sss.pgh.pa.us
Whole thread Raw
In response to Re: cleanup execTuples.c  (Neil Conway <neilc@samurai.com>)
List pgsql-patches
Neil Conway <neilc@samurai.com> writes:
>> For ExecTypeFromTLInternal, maybe use ExecTupDescFromTL, which is a
>> more accurate name in the first place

> What's the logic in having ExecTypeFromTL() and ExecCleanTypeFromTL()
> implemented in terms of a function called ExecTupDescFromTL()? i.e. if
> we're going to be renaming functions, wouldn't it make sense to rename
> the public API functions, not the internal static functions?

My point was that you intended to export ExecTypeFromTLInternal in order
to convert the other names to macros, and I didn't want an exported name
like that.

The number of call sites seems small enough that altering the API isn't
out of the question either, if you like that better.

            regards, tom lane

pgsql-patches by date:

Previous
From: Neil Conway
Date:
Subject: Re: LISTEN/NOTIFY regression tests
Next
From: Manfred Koizar
Date:
Subject: Re: LISTEN/NOTIFY regression tests