Re: ruleutils with pretty-print option - Mailing list pgsql-patches

From Tom Lane
Subject Re: ruleutils with pretty-print option
Date
Msg-id 8978.1059322636@sss.pgh.pa.us
Whole thread Raw
In response to Re: ruleutils with pretty-print option  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: ruleutils with pretty-print option  (Bruce Momjian <pgman@candle.pha.pa.us>)
Re: ruleutils with pretty-print option  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-patches
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Are these illustrating a problem with the function definition, or is it
> happening because it is the first time we are calling the same function
> with one and more than one parameter?

The function definition is broken.  While it could be fixed (by
explicitly testing fcinfo->nargs, rather than assuming positions
beyond nargs are valid) I am not willing to remove the opr_sanity
check that is complaining.  Accordingly, a better solution would be
to make two C-code wrapper functions, one for the single-parameter
and one for the two-parameter case of each function.

            regards, tom lane

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] PATCH: Memory leaks on start-up
Next
From: Bruce Momjian
Date:
Subject: Re: Eliminate information_schema from oid2name listing