Re: [HACKERS] pgxs/windows - Mailing list pgsql-patches

From Tom Lane
Subject Re: [HACKERS] pgxs/windows
Date
Msg-id 8964.1137704061@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] pgxs/windows  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: [HACKERS] pgxs/windows
List pgsql-patches
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Tom Lane wrote:
>> What about the question of whether $(DESTDIR) belongs there or not?
>> I think we had concluded that PGXS shouldn't ever use $(DESTDIR),
>> because that's only for install-time stuff.

> I considered that a separate issue and didn't explore it, but I think
> you are right that $(DESTDIR) makes no sense so I will remove it.

> Patch attached.

If these are bogus then so are the uses in Makefile.aix and
Makefile.darwin.

I'm a bit bothered by the ones in pgxs.mk, too, although I suspect we
have to leave those there for the benefit of contrib?

            regards, tom lane

pgsql-patches by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: [HACKERS] pgxs/windows
Next
From: Bruce Momjian
Date:
Subject: Re: Uninstall scripts for contrib