Re: Australian timezone configure option - Mailing list pgsql-patches

From Tom Lane
Subject Re: Australian timezone configure option
Date
Msg-id 8950.992362949@sss.pgh.pa.us
Whole thread Raw
In response to Re: Australian timezone configure option  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-patches
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Here is a new version of the patch.

It's still horridly ugly.  Why not put the three Aussie-specific entries
in a separate aussie_datetktbl array, and have the lookup look like

    if (Australian_timezones)
    {
        tp = datebsearch(lowtoken, aussie_datetktbl, sz_aussie_datetktbl);
        if (tp == NULL)
            tp = datebsearch(lowtoken, datetktbl, szdatetktbl);
    }
    else
        tp = datebsearch(lowtoken, datetktbl, szdatetktbl);

instead of modifying the lookup table on the fly.

> I found I didn't need to clear the date cache.

Hmm, are you sure about that?  I'm not.

            regards, tom lane

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Australian timezone configure option
Next
From: chris.bitmead@health.gov.au
Date:
Subject: Re: Australian timezone configure option