Re: PL/Python adding support for multi-dimensional arrays - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: PL/Python adding support for multi-dimensional arrays
Date
Msg-id 893c44ec-f8f8-8d1d-749e-e38fd7d427cb@iki.fi
Whole thread Raw
In response to Re: PL/Python adding support for multi-dimensional arrays  (Pavel Stehule <pavel.stehule@gmail.com>)
Responses Re: PL/Python adding support for multi-dimensional arrays  (Pavel Stehule <pavel.stehule@gmail.com>)
List pgsql-hackers
On 10/24/2016 10:33 PM, Pavel Stehule wrote:
> Hi
>
> 2016-10-14 10:53 GMT+02:00 Heikki Linnakangas <hlinnaka@iki.fi>:
>
>> Please review. Are the docs and the error messages now clear enough on
>> this? We'll need a mention in the release notes too, when it's time for
>> that.
>
> The error message is clear.

Ok, great!

> I tested patches - and the regression test is broken (is not actualized)

Ah, fixed.

> There are no new tests for multidimensional array of composites - there is
> only new negative test.

Added one.

Thanks for the review! Committed, with those little fixes, and some 
little last-minute comment tweaks.

- Heikki




pgsql-hackers by date:

Previous
From: "Tsunakawa, Takayuki"
Date:
Subject: Re: [bug fix] Stats collector is not restarted on the standby
Next
From: Heikki Linnakangas
Date:
Subject: Re: Typo in pgstat.h