Re: [bug+patch] Inserting DEFAULT into generated columns from VALUES RTE - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [bug+patch] Inserting DEFAULT into generated columns from VALUES RTE
Date
Msg-id 89193.1606148181@sss.pgh.pa.us
Whole thread Raw
In response to Re: [bug+patch] Inserting DEFAULT into generated columns from VALUES RTE  (Dean Rasheed <dean.a.rasheed@gmail.com>)
List pgsql-hackers
Dean Rasheed <dean.a.rasheed@gmail.com> writes:
> On Sun, 22 Nov 2020 at 20:58, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> However, I think that just adjusting the error string would be
>> helpful, as attached.

> +1

>> (I'm also wondering why the second case is generic ERRCODE_SYNTAX_ERROR
>> and not ERRCODE_GENERATED_ALWAYS.  Didn't change it here, though.)

> I can't see any reason for it to be different, and
> ERRCODE_GENERATED_ALWAYS seems like the right code to use for both
> cases.

Sounds good to me; pushed that way.

            regards, tom lane



pgsql-hackers by date:

Previous
From: "David G. Johnston"
Date:
Subject: Re: abstract Unix-domain sockets
Next
From: Alvaro Herrera
Date:
Subject: Re: pg_proc.dat "proargmodes is not a 1-D char array"