Re: [HACKERS] Bizarre choice of case for RELKIND_PARTITIONED_TABLE - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] Bizarre choice of case for RELKIND_PARTITIONED_TABLE
Date
Msg-id 8913.1488927818@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] Bizarre choice of case for RELKIND_PARTITIONED_TABLE  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: [HACKERS] Bizarre choice of case for RELKIND_PARTITIONED_TABLE  (Robert Haas <robertmhaas@gmail.com>)
Re: [HACKERS] Bizarre choice of case for RELKIND_PARTITIONED_TABLE  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Tue, Mar 7, 2017 at 12:55 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Is there a good reason why RELKIND_PARTITIONED_TABLE is 'P' not 'p'?

> I can't muster a lot of outrage about this one way or another.  One
> possible advantage of 'P' is that there are fewer places where 'P' is
> mentioned in the source code than 'p'.

Hm, one would hope that the vast majority of code references are neither
of those, but rather "RELKIND_PARTITIONED_TABLE".  information_schema.sql
and system_views.sql will need to be gone over carefully, certainly, but
we shouldn't be hard-coding this anywhere that there's a reasonable
alternative.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Vladimir Sitnikov
Date:
Subject: Re: [HACKERS] Statement-level rollback
Next
From: Neha Khatri
Date:
Subject: Re: [HACKERS] [NOVICE] opr_charset rule in gram.y