Re: BUG #14208: Inconsistent code modification - 3 - Mailing list pgsql-bugs

From Tom Lane
Subject Re: BUG #14208: Inconsistent code modification - 3
Date
Msg-id 8904.1467305947@sss.pgh.pa.us
Whole thread Raw
In response to Re: BUG #14208: Inconsistent code modification - 3  (Andres Freund <andres@anarazel.de>)
Responses Re: BUG #14208: Inconsistent code modification - 3  (Andres Freund <andres@anarazel.de>)
List pgsql-bugs
Andres Freund <andres@anarazel.de> writes:
> On 2016-06-30 12:51:51 -0400, Tom Lane wrote:
>> But doesn't the code stanza just above this loop pull that spillage
>> back in?

> If so, sure, it pulls changes back in, but only the first
> static const Size max_changes_in_memory = 4096;
> ones. We should never reconstruct a whole large transaction in memory...

OK, so the failure case is not "empty top level transaction", but
"top level transaction small enough to not have spilled", plus a
spilled subtransaction, correct?

            regards, tom lane

pgsql-bugs by date:

Previous
From: Andres Freund
Date:
Subject: Re: BUG #14208: Inconsistent code modification - 3
Next
From: Andres Freund
Date:
Subject: Re: BUG #14208: Inconsistent code modification - 3