Re: BTScanOpaqueData size slows down tests - Mailing list pgsql-hackers

From Tom Lane
Subject Re: BTScanOpaqueData size slows down tests
Date
Msg-id 886736.1743610243@sss.pgh.pa.us
Whole thread Raw
In response to Re: BTScanOpaqueData size slows down tests  (Peter Geoghegan <pg@bowt.ie>)
Responses Re: BTScanOpaqueData size slows down tests
List pgsql-hackers
Peter Geoghegan <pg@bowt.ie> writes:
> It isn't at all rare for the scan to have to return about 1350 TIDs
> from a page, though. Any low cardinality index will tend to have
> almost that many TIDs to return on any page that only stores
> duplicates. And scan will necessarily have to return all of the TIDs
> from such a page, if it has to return any.

Agreed, but scans that just return one item are also very common,
particularly in the syscache-miss case that Andres started with.

I could get behind the idea of just having enough space in
BTScanOpaqueData for about ten items, and dynamically allocating
a MaxTIDsPerBTreePage-sized array only if we overrun that.
And not allocate any space for mark/restore unless a mark is
done.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: BTScanOpaqueData size slows down tests
Next
From: Peter Geoghegan
Date:
Subject: Re: BTScanOpaqueData size slows down tests