Re: segmentation fault using currtid and partitioned tables - Mailing list pgsql-hackers

From Tom Lane
Subject Re: segmentation fault using currtid and partitioned tables
Date
Msg-id 8856.1590714710@sss.pgh.pa.us
Whole thread Raw
In response to Re: segmentation fault using currtid and partitioned tables  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> On 2020-04-05 12:51:56 -0400, Tom Lane wrote:
>> I think it might be a good idea to make relations-without-storage
>> set up rd_tableam as a vector of dummy functions that will throw
>> some suitable complaint about "relation lacks storage".  NULL is
>> a horrible default for this.

> OTOH, it's kinda annoying having to maintain a not insignificant number
> of functions that needs to be updated whenever the tableam interface
> evolves.

That argument sounds pretty weak.  If you're making breaking changes
in the tableam API, updating the signatures (not even any code) of
some dummy functions seems like by far the easiest part.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Andy Fan
Date:
Subject: Re: Make the qual cost on index Filter slightly higher than qual coston index Cond.
Next
From: Jeff Davis
Date:
Subject: Re: Trouble with hashagg spill I/O pattern and costing