Re: Better shared data structure management and resizable shared data structures - Mailing list pgsql-hackers

Heikki Linnakangas <hlinnaka@iki.fi> writes:

> Those are now committed, and here's a new version rebased over those
> changes.

I noticed this bit during my habitual morning skim of new commits:

> diff --git a/src/backend/utils/misc/injection_point.c b/src/backend/utils/misc/injection_point.c
> index c06b0e9b800..9981d6e212f 100644
> --- a/src/backend/utils/misc/injection_point.c
> +++ b/src/backend/utils/misc/injection_point.c
> @@ -17,6 +17,7 @@
>   */
>  #include "postgres.h"
>  
> +#include "storage/subsystems.h"
>  #include "utils/injection_point.h"
>  
>  #ifdef USE_INJECTION_POINTS
> @@ -109,6 +110,11 @@ typedef struct InjectionPointCacheEntry
>  
>  static HTAB *InjectionPointCache = NULL;
>  
> +#ifdef USE_INJECTION_POINTS
> +static void InjectionPointShmemRequest(void *arg);
> +static void InjectionPointShmemInit(void *arg);
> +#endif
> +

This is already inside an `#ifdef USE_INJECTION_POINTS` guard (in fact
visible at the end of the previous diff hunk), no need for another one.

- ilmari