Re: logical copy_replication_slot issues - Mailing list pgsql-hackers

From Arseny Sher
Subject Re: logical copy_replication_slot issues
Date
Msg-id 87v9oelex6.fsf@ars-thinkpad
Whole thread Raw
In response to Re: logical copy_replication_slot issues  (Masahiko Sawada <masahiko.sawada@2ndquadrant.com>)
Responses Re: logical copy_replication_slot issues
List pgsql-hackers
Masahiko Sawada <masahiko.sawada@2ndquadrant.com> writes:

> I've attached the draft patch fixing this issue but I'll continue
> investigating it more deeply.

There also should be a check that source slot itself has consistent
snapshot (valid confirmed_flush) -- otherwise it might be possible to
create not initialized slot which is probably not an error, but weird
and somewhat meaningless. Paranoically, this ought to be checked in both
src slot lookups.

With this patch it seems like the only thing
create_logical_replication_slot does is ReplicationSlotCreate, which
questions the usefulness of this function. On the second look,
CreateInitDecodingContext checks plugin sanity (ensures it exists), so
probably it's fine.


-- cheers, arseny



pgsql-hackers by date:

Previous
From: Craig Ringer
Date:
Subject: Re: Postgres 32 bits client compilation fail. Win32 bits client is supported?
Next
From: Dmitry Igrishin
Date:
Subject: Is it memory leak or not?