Re: Open items for 8.2 - Mailing list pgsql-hackers

From Christopher Browne
Subject Re: Open items for 8.2
Date
Msg-id 87u03lzvc4.fsf@wolfe.cbbrowne.com
Whole thread Raw
In response to Re: Open items for 8.2  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
Centuries ago, Nostradamus foresaw when tgl@sss.pgh.pa.us (Tom Lane) would write:
> Bruce Momjian <bruce@momjian.us> writes:
>> Chris Browne wrote:
>>> I've got suggested patches for my item (e.g. - --with-openssl causing
>>> contrib stuff to break on AIX); a couple of instances of:
>>> 
>>> SHLIB_LINK = $(libpq) $(LIBS)
>>> 
>>> in contrib/dblink/Makefile and contrib/sslinfo seem to do the trick.
>>> I'm not sure of adverse effects for others, so that's only speculative
>>> at this point...
>
>> My guess is that sslinfo needs it because of the use of the SSL
>> libraries.
>
> I just added $(LIBS) to sslinfo's Makefile to fix its build failure on
> Darwin.  (I see no reason why libpq should be involved there,
> though.)

> I'm unclear on why AIX would need more than Darwin does to get dblink
> to build.

In the case of dblink/Makefile, it started as 

SHLIB_LINK = $(libpq)

which need to be augmented to:

SHLIB_LINK = $(libpq) $(LIBS)

When I saw the same errors pop up with sslinfo, there was no
SHLIB_LINK definition, so went to:

SHLIB_LINK = $(libpq) $(LIBS)

It's entirely possible that
SHLIB_LINK = $(LIBS)
is sufficient.
-- 
wm(X,Y):-write(X),write('@'),write(Y). wm('cbbrowne','gmail.com').
http://linuxfinances.info/info/spreadsheets.html
"We defeated the enemy with teamwork and the hammer of not bickering."
-- The Shoveller, Mystery Men


pgsql-hackers by date:

Previous
From: Jeff Davis
Date:
Subject: Re: New Linux Filesystem: NILFS
Next
From: Tom Lane
Date:
Subject: Re: @ versus ~, redux