Re: Patch to fix write after end of array in hashed agg initialization - Mailing list pgsql-hackers

From Andrew Gierth
Subject Re: Patch to fix write after end of array in hashed agg initialization
Date
Msg-id 87pnoac8ie.fsf@news-spur.riddles.org.uk
Whole thread Raw
In response to Re: Patch to fix write after end of array in hashed agg initialization  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Patch to fix write after end of array in hashed agg initialization  (Andrew Gierth <andrew@tao11.riddles.org.uk>)
List pgsql-hackers
>>>>> "Tom" == Tom Lane <tgl@sss.pgh.pa.us> writes:

 >> Attached is a patch for a write after allocated memory which we
 >> found in testing. Its an obscure case but can happen if the same
 >> column is used in different grouping keys, as in the example below,
 >> which uses tables from the regress test suite (build with
 >> --enable-cassert in order to turn on memory warnings). Patch is
 >> against master.

 Tom> I confirm the appearance of the memory-overwrite warnings in HEAD.

 Tom> It looks like the bad code is (mostly) the fault of commit
 Tom> b5635948. Andrew, can you take a look at this fix?

I'll look into it.

-- 
Andrew (irc:RhodiumToad)



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: pg_dump throwing "column number -1 is out of range 0..36" on HEAD
Next
From: Michael Paquier
Date:
Subject: Re: with oids option not removed in pg_dumpall