Re: A assert failure when initdb with track_commit_timestamp=on - Mailing list pgsql-hackers

From Andy Fan
Subject Re: A assert failure when initdb with track_commit_timestamp=on
Date
Msg-id 87plea9q4x.fsf@163.com
Whole thread Raw
List pgsql-hackers
Fujii Masao <masao.fujii@oss.nttdata.com> writes:

> Shouldn't we also add a TAP test to verify that initdb works correctly
> with GUCs marked as GUC_NOT_IN_BOOTSTRAP?

After revert 5a6c39b6d, the test case could be as simply as below: I
also tested this change. Just FYI.

modified   src/test/modules/commit_ts/t/001_base.pl
@@ -11,8 +11,7 @@ use Test::More;
 use PostgreSQL::Test::Cluster;
 
 my $node = PostgreSQL::Test::Cluster->new('foxtrot');
-$node->init;
-$node->append_conf('postgresql.conf', 'track_commit_timestamp = on');
+$node->init(extra => ['-c', 'track_commit_timestamp=on', "-c", "transaction_timeout=10s" ]);
 $node->start;
 
# Create a table, compare "now()" to the commit TS of its xmin

-- 
Best Regards
Andy Fan




pgsql-hackers by date:

Previous
From: Paul Jungwirth
Date:
Subject: Fix comment in btree_gist--1.8--1.9.sql
Next
From: Michael Paquier
Date:
Subject: Re: Move the injection_points extension to contrib?