Re: constants for tar header offsets - Mailing list pgsql-hackers

From Dagfinn Ilmari Mannsåker
Subject Re: constants for tar header offsets
Date
Msg-id 87o7nluo1g.fsf@wibble.ilmari.org
Whole thread Raw
In response to constants for tar header offsets  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: constants for tar header offsets
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:

> On Tue, Apr 18, 2023 at 12:06 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Hmm, you're right: I checked the POSIX.1-2018 spec as well, and
>> it agrees that the prefix field is 155 bytes long.  Perhaps just
>> add another comment line indicating that 12 bytes remain unassigned?
>
> OK. Here's v2, with that change and a few others.

It still has magic numbers for the sizes of the fields, should those
also be named constants?

- ilmari



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: constants for tar header offsets
Next
From: Aleksander Alekseev
Date:
Subject: Re: [PATCH] Compression dictionaries for JSONB