Re: Parallel query hangs after a smart shutdown is issued - Mailing list pgsql-hackers

From Arseny Sher
Subject Re: Parallel query hangs after a smart shutdown is issued
Date
Msg-id 87mu2xjlbn.fsf@ars-thinkpad
Whole thread Raw
In response to Re: Parallel query hangs after a smart shutdown is issued  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Parallel query hangs after a smart shutdown is issued
List pgsql-hackers
Tom Lane <tgl@sss.pgh.pa.us> writes:

> Thomas Munro <thomas.munro@gmail.com> writes:
>> On Fri, Aug 14, 2020 at 4:45 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> After some more rethinking and testing, here's a v5 that feels
>>> fairly final to me.  I realized that the logic in canAcceptConnections
>>> was kind of backwards: it's better to check the main pmState restrictions
>>> first and then the smart-shutdown restrictions afterwards.
>
>> LGTM.  I tested this a bit today and it did what I expected for
>> parallel queries and vacuum, on primary and standby.
>
> Thanks for reviewing!  I'll do the back-patching and push this today.

FWIW, I've also looked through the patch and it's fine. Moderate testing
also found no issues, check-world works, bgws are started during smart
shutdown as expected. And surely this is better than the inital
shorthack of allowing only parallel workers.



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: jsonb, collection & postgres_fdw
Next
From: vignesh C
Date:
Subject: Re: Parallel copy