Re: WITHIN GROUP patch - Mailing list pgsql-hackers

From Andrew Gierth
Subject Re: WITHIN GROUP patch
Date
Msg-id 87lhzwcpmm.fsf@news-spur.riddles.org.uk
Whole thread Raw
In response to Re: WITHIN GROUP patch  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: WITHIN GROUP patch
List pgsql-hackers
>>>>> "Tom" == Tom Lane <tgl@sss.pgh.pa.us> writes:
Tom> After examining this more closely, ISTM that the directTom> arguments are supposed to be processed as if they
weren'tinsideTom> an aggregate call at all.  That being the case, isn't it flatTom> out wrong for check_agg_arguments()
tobe examining theTom> agg_ordset list?  It should ignore those expressions whilstTom> determining the aggregate's
semanticlevel.  As an example, anTom> upper-level Var in those expressions isn't grounds for decidingTom> that the
aggregateisn't of the current query level.
 

Hmm... yes, you're probably right; but we'd still have to check somewhere
for improper nesting, no? since not even the direct args are allowed to
contain nested aggregate calls.

-- 
Andrew (irc:RhodiumToad)



pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist
Next
From: Pavel Stehule
Date:
Subject: Re: plpgsql_check_function - rebase for 9.3