Re: BUG #16931: source code problem about commit_ts - Mailing list pgsql-bugs

From Andy Fan
Subject Re: BUG #16931: source code problem about commit_ts
Date
Msg-id 87jz4p9z6g.fsf@163.com
Whole thread Raw
In response to Re: BUG #16931: source code problem about commit_ts  (Fujii Masao <masao.fujii@oss.nttdata.com>)
List pgsql-bugs
Fujii Masao <masao.fujii@oss.nttdata.com> writes:

>>>
>>> Thanks for the ping! Pushed!
>> Did this commit(08aa89b326261b669648df97d4f2a6edba22d26a) forget to
>> remove struct xl_commit_ts_set?
>
> You're right. I seem to have overlooked that.
>
>> After it, there is no reference to
>> xl_commit_ts_set. So Is it better clean them as well?
>
> Agreed, the patch looks good to me. Unless there are objections,
> I'll go ahead and commit it.

Thank you Fujii!

> While this could be considered an oversight in the original commit,
> it's not a bug fix, so I plan to apply it only to the master branch. 

That makes sense to me.

-- 
Best Regards
Andy Fan




pgsql-bugs by date:

Previous
From: Laurenz Albe
Date:
Subject: Re: BUG #18976: -0.0 with float8 will be transformed to 0 inprepare statement but not in normal execution
Next
From: "ZhangChi"
Date:
Subject: Re: BUG #18976: -0.0 with float8 will be transformed to 0 inpreparestatement but not in normal execution