>>>>> "Peter" == Peter Geoghegan <pg@heroku.com> writes:
Peter> You'll probably prefer the attached. This patch works byPeter> disabling abbreviation, but only after writing
outruns, withPeter> the final merge left to go. That way, it doesn't matter whenPeter> abbreviated keys are not read
backfrom disk (or regenerated).
This seems tolerable to me for a quick fix. The merits of storing the
abbreviation vs. re-abbreviating on input can be studied later.
Peter> I believe this bug was missed because it only occurs when therePeter> are multiple runs, and not in the common
casewhere there is onePeter> big initial run that is found already sorted when we reachPeter> mergeruns().
Ah, yes, there is an optimization for the one-run case which bypasses
all further comparisons, hiding the problem.
--
Andrew (irc:RhodiumToad)
