Re: bool_plperl transform - Mailing list pgsql-hackers

From ilmari@ilmari.org (Dagfinn Ilmari Mannsåker)
Subject Re: bool_plperl transform
Date
Msg-id 87h7z7wwv2.fsf@wibble.ilmari.org
Whole thread Raw
In response to Re[2]: bool_plperl transform  (Wao <wao@mail.ru>)
Responses Re[2]: bool_plperl transform  (Ivan Panchenko <wao@mail.ru>)
List pgsql-hackers
Wao <wao@mail.ru> writes:

> +Datum
> +bool_to_plperl(PG_FUNCTION_ARGS)
> +{
> +    dTHX;
> +    bool in = PG_GETARG_BOOL(0);
> +    SV    *sv = newSVnv(SvNV(in ? &PL_sv_yes : &PL_sv_no));
> +    return PointerGetDatum(sv);
> +}

Why is this only copying the floating point part of the built-in
booleans before returning them?  I think this should just return
&PL_sv_yes or &PL_sv_no directly, like boolean expressions in Perl do,
and like what happens for NULL (&PL_sv_undef).

- ilmari
-- 
"A disappointingly low fraction of the human race is,
 at any given time, on fire." - Stig Sandbeck Mathisen



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Commitfest 2020-03 Now in Progress
Next
From: Tom Lane
Date:
Subject: Re: Allow to_date() and to_timestamp() to accept localized names