Re: add function for creating/attaching hash table in DSM registry - Mailing list pgsql-hackers

Nathan Bossart <nathandbossart@gmail.com> writes:

> +typedef struct NamedDSMHashState
> +{
> +    dsa_handle    dsah;
> +    dshash_table_handle dshh;
> +    int            dsa_tranche;
> +    char        dsa_tranche_name[68];    /* name + "_dsa" */
> +    int            dsh_tranche;
> +    char        dsh_tranche_name[68];    /* name + "_dsh" */
> +} NamedDSMHashState;

I don't have enough knowledge to review the rest of the patch, but
shouldn't this use NAMEDATALEN, rather than hard-coding the default
length?

- ilmari