Re: FUNC_MAX_ARGS benchmarks - Mailing list pgsql-hackers

From Neil Conway
Subject Re: FUNC_MAX_ARGS benchmarks
Date
Msg-id 87d6sm4gpc.fsf@klamath.dyndns.org
Whole thread Raw
In response to Re: FUNC_MAX_ARGS benchmarks  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: FUNC_MAX_ARGS benchmarks
Re: FUNC_MAX_ARGS benchmarks
List pgsql-hackers
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> I have applied the attached patch which changes NAMEDATALEN to 64 and
> FUNC_MAX_ARGS/INDEX_MAX_KEYS to 32.

What is the reasoning behind the following change?

Index: src/bin/psql/command.c
===================================================================
RCS file: /cvsroot/pgsql-server/src/bin/psql/command.c,v
retrieving revision 1.75
diff -c -r1.75 command.c
*** src/bin/psql/command.c    10 Aug 2002 03:56:23 -0000    1.75
--- src/bin/psql/command.c    13 Aug 2002 20:18:01 -0000
***************
*** 1513,1519 ****     sys = malloc(strlen(editorName) + strlen(fname) + 32 + 1);     if (!sys)         return false;
!     sprintf(sys, "exec %s %s", editorName, fname);     result = system(sys);     if (result == -1)
psql_error("couldnot start editor %s\n", editorName);
 
--- 1513,1519 ----     sys = malloc(strlen(editorName) + strlen(fname) + 32 + 1);     if (!sys)         return false;
!     snprintf(sys, 32, "exec %s %s", editorName, fname);     result = system(sys);     if (result == -1)
psql_error("couldnot start editor %s\n", editorName);
 

Cheers,

Neil

-- 
Neil Conway <neilconway@rogers.com>
PGP Key ID: DB3C29FC



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: FUNC_MAX_ARGS benchmarks
Next
From: Bruce Momjian
Date:
Subject: Re: FUNC_MAX_ARGS benchmarks