Re: Record queryid when auto_explain.log_verbose is on - Mailing list pgsql-hackers

On 2023-01-26 12:40, Michael Paquier wrote:
> On Wed, Jan 25, 2023 at 04:46:36PM +0900, Michael Paquier wrote:
>> Thanks.  Will check and probably apply on HEAD.
> 
> Done, after adding one test case with compute_query_id=regress and
> applying some indentation.
> --
> Michael

Thanks!

>> On 2023-01-23 09:35, Michael Paquier wrote:
>>> ExplainPrintTriggers() is kind of different because there is
>>> auto_explain_log_triggers.  Still, we could add a flag in 
>>> ExplainState
>>> deciding if the triggers should be printed, so as it would be 
>>> possible
>>> to move ExplainPrintTriggers() and ExplainPrintJITSummary() within
>>> ExplainPrintPlan(), as well?  The same kind of logic could be applied
>>> for the planning time and the buffer usage if these are tracked in
>>> ExplainState rather than being explicit arguments of 
>>> ExplainOnePlan().
>>> Not to mention that this reduces the differences between
>>> ExplainOneUtility() and ExplainOnePlan().

I'll work on this next.

-- 
Regards,

--
Atsushi Torikoshi
NTT DATA CORPORATION