Re: add more frame types in window functions (ROWS) - Mailing list pgsql-hackers

From Andrew Gierth
Subject Re: add more frame types in window functions (ROWS)
Date
Msg-id 87bpidn1tg.fsf@news-spur.riddles.org.uk
Whole thread Raw
In response to Re: add more frame types in window functions (ROWS)  (Hitoshi Harada <umi.tanuki@gmail.com>)
List pgsql-hackers
>>>>> "Hitoshi" == Hitoshi Harada <umi.tanuki@gmail.com> writes:
Hitoshi> One thing for rule test, I checked existing regression testHitoshi> cases and concluded DROP VIEW is
necessary,or even VIEWHitoshi> test for a specific feature is not needed. I remember yourHitoshi> aggregate ORDER BY
patchcontains "rules" testHitoshi> changes. However, since processing order of regression testsHitoshi> is not
predictableand may change AFAIK, I guess itHitoshi> shouldn't add those changes in rules.out.
 

Actually, looking more closely, the way you have it currently works only
by chance - "rules" and "window" are running in parallel, therefore the
view creation in "window" can break the output of "rules".

The order of regression tests is set in parallel_schedule and
serial_schedule; it's unpredictable only for tests within the same
parallel group.

I think a modification of the schedule is needed here; the only other
option would be to move the view creation into a different test.

-- 
Andrew.


pgsql-hackers by date:

Previous
From: Hitoshi Harada
Date:
Subject: Re: add more frame types in window functions (ROWS)
Next
From: Robert Haas
Date:
Subject: Re: Adding support for SE-Linux security