Re: Prettification versus dump safety - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Prettification versus dump safety
Date
Msg-id 8795.1258752339@sss.pgh.pa.us
Whole thread Raw
In response to Re: Prettification versus dump safety  (Andreas Pflug <pgadmin@pse-consulting.de>)
List pgsql-hackers
Andreas Pflug <pgadmin@pse-consulting.de> writes:
> Tom Lane wrote:
>> The easy ways out of this are
>> (1) change pg_dump to not prettify trigger definitions at all, or
>> (2) change pg_get_triggerdef from the submitted patch so that it
>> doesn't reduce parenthesization even in "pretty" mode.
>> 
> The pretty option was explicitely never intended for pg_dump use.

Yeah.  I went with (1) because it's something we can undo in future
on the pg_dump side.  The alternative is to immortalize an arbitrary
deviation of pg_get_triggerdef's pretty-fying behavior compared to
every other ruleutils.c function.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: TRIGGER with WHEN clause
Next
From: Tom Lane
Date:
Subject: Re: Why do OLD and NEW have special internal names?