Re: [HACKERS] [sqlsmith] crash in RestoreLibraryState during low-memory testing - Mailing list pgsql-hackers

From Andreas Seltenreich
Subject Re: [HACKERS] [sqlsmith] crash in RestoreLibraryState during low-memory testing
Date
Msg-id 878tgsu2y5.fsf@ansel.ydns.eu
Whole thread Raw
In response to Re: [HACKERS] [sqlsmith] crash in RestoreLibraryState during low-memory testing  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [HACKERS] [sqlsmith] crash in RestoreLibraryState duringlow-memory testing  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Tom Lane writes:

> Presumably somebody could dig into the libc source code and prove or
> disprove this, though it would sure help to know exactly what platform
> and version Andreas is testing on.

This is the code in glibc-2.24 around the crash site:

,----[ glibc-2.24/elf/dl-load.c:442 ]
|       to_free = cp = expand_dynamic_string_token (l, cp, 1);
|
|       size_t len = strlen (cp);
`----

…while expand_dynamic_string_token will indeed return NULL on a failed
malloc.  Code in the most recent glibc looks the same, so I'll carry
this issue over to the glibc bugzilla then.

Sorry about the noise…
Andreas


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: [HACKERS] pnstrdup considered armed and dangerous
Next
From: Kyotaro HORIGUCHI
Date:
Subject: Re: [HACKERS] [PATCH] Improve geometric types