Re: Get rid of translation strings that only contain punctuation - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Get rid of translation strings that only contain punctuation
Date
Msg-id 878402.1776819108@sss.pgh.pa.us
Whole thread
In response to Get rid of translation strings that only contain punctuation  (David Rowley <dgrowleyml@gmail.com>)
List pgsql-hackers
David Rowley <dgrowleyml@gmail.com> writes:
> We've got a few parts of the code that translate strings that contain
> only a single punctuation character. I'm not a translator, but I
> suspect that these would be tricky to deal with as such short strings
> could be used for various different things, and if the required
> translation was to differ between requirements, then you're out of
> luck.

Yeah.  I concur with your feeling that a separate translatable string
containing just a punctuation mark is probably the Wrong Thing.  But
just removing the translation marker doesn't fix the problem.  You
need more extensive restructuring so that what needs to be translated
is a coherent message.

We previously discussed the append_tuple_value_detail case [1], and
I opined that the right fix was to change things so that what that
function produces is a string that doesn't need translation because
it matches SQL syntax for a row constructor.  It doesn't look like
that's happened yet.

            regards, tom lane

[1] https://www.postgresql.org/message-id/227279.1775956328%40sss.pgh.pa.us



pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Get rid of translation strings that only contain punctuation
Next
From: jian he
Date:
Subject: Re: FOR PORTION OF does not recompute GENERATED STORED columns that depend on the range column