Re: pg_stat_reset round 2 - Mailing list pgsql-patches

From Neil Conway
Subject Re: pg_stat_reset round 2
Date
Msg-id 877kj5loyi.fsf@klamath.dyndns.org
Whole thread Raw
In response to pg_stat_reset round 2  ("Christopher Kings-Lynne" <chriskl@familyhealth.com.au>)
Responses Re: pg_stat_reset round 2  ("Christopher Kings-Lynne" <chriskl@familyhealth.com.au>)
List pgsql-patches
"Christopher Kings-Lynne" <chriskl@familyhealth.com.au> writes:
> This is a reworked patch.  It makes pg_stat_reset() a documented builtin
> function.  It requires superuser privileges to execute.  The committer
> should check my pg_proc.h entry to make sure I've set isstrict, volatility,
> etc. correctly...

It should be marked volatile (rather than stable), as it has
side-effects.

Wouldn't PG_RETURN_VOID() be more appropriate than returning true?

Cheers,

Neil

--
Neil Conway <neilconway@rogers.com>
PGP Key ID: DB3C29FC

pgsql-patches by date:

Previous
From: "Christopher Kings-Lynne"
Date:
Subject: pg_stat_reset round 2
Next
From: "Christopher Kings-Lynne"
Date:
Subject: Re: pg_stat_reset round 2